Apps Scopes developed, steps to push?

mgiganto

Hi,

I have been developing apps scope functionality for GrapheneOS and seems to be working, I would like to push it to the project so others can benefit from it.
At the moment, the implementation impact the following files:
/system/framework/framework.jar
/system/framework/services.jar
/system_ext/priv-app/Settings/Settings.apk
/system_ext/priv-app/Launcher3QuickStep/Launcher3QuickStep.apk

It modifies 3 different repositories:
https://github.com/GrapheneOS/platform_frameworks_base
https://github.com/GrapheneOS/platform_packages_apps_Launcher3
https://github.com/GrapheneOS/platform_packages_apps_Settings

I never made any contribution to GrapheneOS, so I am not sure how should I proceed, specially because it touch 3 projects together and it needs to be in sync.
I would like to avoid having PRs running for ever if it is possible, so I am seeking for advice about how to accomplish it in advance.

Main points of what it is implemented for now:
Individual configuration to each application to enable/disable apps scopes.
A browser of all apps that the targeted app is able to see naturally, including system apps.
Any application can be hided to one particular target, using 2 methods:
*Blacklist: hide specific applications, while the default rule is not hide.
*Whitelist: hide everything unless you specifically allow an app to be seen.
The method of whitelist/blacklist can be setup individually for user apps, and system apps.
A quick option to wipe out the apps scopes configuration of the app
A quick option to restrict everything on the app.
It is integrated in the launcher so when you hold onto an app with the apps scopes enabled, you can see a shortcut to the apps scopes configuration of that app.

DohnJoe

mgiganto
Even if this contribution might take its time to be part of the project, thank you very much for your efforts :)

wizoatk

Contributions related to existing issues or creating new issues are discussed on github.

https://github.com/GrapheneOS/os-issue-tracker

Your proposal seems to have a degree of overlap with:

app communication/visibility scopes for non-system components #2197
https://github.com/GrapheneOS/os-issue-tracker/issues/2197

mgiganto

Thank you @wizoatk

wizoatk

mgiganto

I see that you've made contact with project on github. Hopefully you recognized who responded. At this point up to you how/if you want to proceed.

mgiganto

Honestly, I did not, mainly because it is the first time that I pay this close attention to the repository itself, but I got the impression that he can made decisions about if it is going into mainstream or not, so hopefully it goes there soon, to help on that i am auditing the code and applying improvements to the code, so soon all the revised code will be pushed, so at least people can test and help to improve it.

Thank you again @wizoatk for pointing me to there :D

AcclaimSublevel19

mgiganto The person who replied is Daniel Micay, the lead GrapheneOS developer.

Probably9857

AcclaimSublevel19 Daniel Micay, the lead GrapheneOS developer.

Minor correction: he is the founder, but no longer the lead developer.

wuseman

Probably9857 Who is currently the lead developer then?

Probably9857

wuseman

I believe @muhomorr, but I'm not certain.

schweizer

Hm, looks like it was rejected. I am missing a list of functionalities that a successful PR would have to meet.

mgiganto

I did not try yet the PR, but getting close. I have been doing a lot of polishing in the code from the original PoC, but I believe I am done with code changes, just some extra testing and update the code to latest release, because my current code is based on 2026011300, but I don't think is there is a significant change since 2026011300.

mgiganto

Baby is out, if anybody is interested in giving it a try, here are the PRs needed:
Launcher PR: https://github.com/GrapheneOS/platform_packages_apps_Launcher3/pull/66
Settings PR: https://github.com/GrapheneOS/platform_packages_apps_Settings/pull/412
Frameworks PR: https://github.com/GrapheneOS/platform_frameworks_base/pull/314

GrapheneOS

It's far from being a complete implementation and isn't something we can merge without a massive amount of additional development work on it. Privacy and security features for GrapheneOS need to have a clear set of goals and need to accomplish those goals. If it only removes certain ways to do it with the information still available other ways then that's not something we'll merge.