Thought I had the same issue. Turns out the edit 'pencil' is always black, so on contact photos with a black background you just can't see the pencil.
Find one where it is visible and remember the location on the screen. Then tap in the same spot to edit a contact where the pencil is hidden.